Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run STPImageLibraryTests on iOS 9 using new AssertEqualImages macro from #976 #1005

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

danj-stripe
Copy link
Contributor

Summary

Same problem as d1e3669, but they were disabled to avoid
build failures.

Now that we have a (hack/workaround) for image equality tests, use it.

Motivation

Run more tests during CI on older devices.

Testing

Ran the tests locally using the command from the build script.

…ro from #976

Same problem as d1e3669, but they were disabled to avoid
build failures.

Now that we have a (hack/workaround) for image equality tests, use it.
Copy link
Contributor

@csabol-stripe csabol-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!

@danj-stripe danj-stripe merged commit 8624f80 into master Aug 6, 2018
@danj-stripe danj-stripe deleted the danj/bugfix/image-equality-assertion branch August 6, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants