Update examples #1363
Merged
Update examples #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmendation. Dont pass amount from the client - security antipattern
davidme-stripe
approved these changes
Sep 9, 2019
|
🎉woo, automatic confirmation We should update the docs to match. |
davidme-stripe
approved these changes
Sep 13, 2019
| @@ -17,7 +17,7 @@ class StandardIntegrationUITests: XCTestCase { | |||
| // UI tests must launch the application that they test. Doing this in setup will make sure it happens for each test method. | |||
| let app = XCUIApplication() | |||
| let stripePublishableKey = "pk_test_6Q7qTzl8OkUj5K5ArgayVsFD00Sa5AHMj3" | |||
| let backendBaseURL = "https://stripe-mobile-test-backend.herokuapp.com/" | |||
| let backendBaseURL = "https://stripe-mobile-test-backend-17.herokuapp.com/" | |||
There was a problem hiding this comment.
Hah, forgot that versioning would be an issues on these tests. This seems to be an okay workaround, but if it gets too toilsome we should figure out something else.
ramont-stripe
pushed a commit
that referenced
this pull request
Aug 15, 2022
* Make phone optional by default * upper case county codes * Only suggest line 1 for auto complete * Expand address section when auto complete line is tapped if needed * update snapshots * update test * Revert "upper case county codes" This reverts commit c17b78a6c233089a06574ee7b7029bb2a23bfc31. * Uppercase country codes in address section element * Revert "Expand address section when auto complete line is tapped if needed" This reverts commit c9c47ca34046bcde98911188f9c07fdfcd3a21bc. * Remove un-needed beginEditing call * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Sync examples with what docs recommend stripe/example-mobile-backend#67
Testing
All the Custom Integration Card example flows, Standard Integration.