Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay intent creation and open 'add' if no saved payment methods #2473

Merged
merged 5 commits into from
Apr 18, 2023

Conversation

wooj-stripe
Copy link
Collaborator

@wooj-stripe wooj-stripe commented Apr 14, 2023

Summary

  • 1: If a customer has no saved payment methods, we automatically open the add payment method view
  • 2: Intent creation was happening when tapping "add" -- we now delay this to when a user taps the "add" button.

Motivation

  • Design feedback for the first item -- and to do this, we needed to do 2.

Testing

manual testing

Before After
delayIntentCreation_before delayIntentCreation_after

@wooj-stripe wooj-stripe requested review from a team as code owners April 14, 2023 23:56
@wooj-stripe wooj-stripe requested review from eurias-stripe and removed request for a team April 14, 2023 23:56
Base automatically changed from wooj/spmsButton to master April 17, 2023 16:27
@wooj-stripe wooj-stripe force-pushed the wooj/spmsButton-addDirectly branch from 6d93067 to 1b6e345 Compare April 17, 2023 16:28
@wooj-stripe wooj-stripe force-pushed the wooj/spmsButton-addDirectly branch from 1b6e345 to 7e517c1 Compare April 17, 2023 23:08
@wooj-stripe wooj-stripe merged commit f899d62 into master Apr 18, 2023
@wooj-stripe wooj-stripe deleted the wooj/spmsButton-addDirectly branch April 18, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants