Identity] Support the 'closed' field in submit endpoint #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ccen-stripe
force-pushed
the
ccen/supportCannotVerify
branch
from
f7fdc58 to
3cdcaf0
Compare
ccen-stripe
force-pushed
the
ccen/IDPROD-5537/phoneVerificationBase
branch
from
ce2e43e to
3ca5e7f
Compare
ccen-stripe
force-pushed
the
ccen/supportCannotVerify
branch
from
753daec to
8972a51
Compare
ccen-stripe
requested review from
vardges-stripe
and removed request for
porter-stripe
...entity/StripeIdentity/Source/NativeComponents/Coordinators/VerificationSheetController.swift
Outdated
Show resolved
Hide resolved
...Identity/StripeIdentity/Source/NativeComponents/ViewControllers/PhoneOtpViewController.swift
Show resolved
Hide resolved
|
Have to move
|
vardges-stripe
approved these changes
Jul 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduced a new
closedboolean in submit API endpoint, after submittingsubmittedandclosedaretrue-> navigate to success pagesubmitted=trueandclosed=false, need to fallback, checkmissingsand fallback accordingly - currently this only happens whenphonetype verification fallback todocumentAndroid change: stripe/stripe-android#6958
Motivation
Support phoneV
Testing
Changelog