-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connect] Prepare to publish StripeConnect module #4035
[Connect] Prepare to publish StripeConnect module #4035
Conversation
5fca70e
to
ca120b7
Compare
f759d22
to
289c7a6
Compare
5bbf80d
to
80135ce
Compare
1802618
to
cf3cbc1
Compare
80135ce
to
dc140d2
Compare
7ee34cb
to
00d6102
Compare
8a68f14
to
60a910a
Compare
baf7731
to
c04f948
Compare
97bb385
to
df4771b
Compare
6f39d37
to
19b7736
Compare
df4771b
to
60a80a3
Compare
7 builds had no size change, 1 build errored
StripeSize 1.0 (1)
|
Name | Message |
---|---|
StripeConnectSize com.stripe.StripeConnectSize |
The diff could not be determined because no build for 59e53e7 was uploaded |
🛸 Powered by Emerge Tools
🚨 New dead code detected in this PR: ConnectWebView.swift: warning: Function 'showErrorAlert(for:)' is unused
ConnectWebView.swift: warning: Function 'download(decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish()' is unused
ConnectWebView.swift: warning: Function 'download(_:decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(_:didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish(_:)' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
0c10880
to
bb8a81d
Compare
080b316
to
b7cb344
Compare
0c8a7f4
to
ddfcff1
Compare
ddfcff1
to
5bde8d8
Compare
📸 Snapshot TestBase build not foundNo build was found for the base commit 59e53e7. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
This is an expected failure because there were no previous builds of StripeConnect for Emerge to compare the size against |
<key>NSCameraUsageDescription</key> | ||
<string>camera description</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connect assertion fails if the app doesn't configure this, so this has been added to all installation test projects
Summary
Prepare for StripeConnect SDK release:
StripeConnect
to package managers and modules.yamlMotivation
https://jira.corp.stripe.com/browse/MXMOBILE-2496
Testing
https://www.emergetools.com/build/14436e05-f195-4a1c-9b30-fc1950750883
Changelog