Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connect] Prepare to publish StripeConnect module #4035

Merged

Conversation

mludowise-stripe
Copy link
Collaborator

@mludowise-stripe mludowise-stripe commented Sep 23, 2024

Summary

Prepare for StripeConnect SDK release:

  • Adds StripeConnect to package managers and modules.yaml
  • Configures installation tests
  • Adds to modules list in main README
  • Adds changelog entry

Motivation

https://jira.corp.stripe.com/browse/MXMOBILE-2496

Testing

Changelog

[Added] StripeConnect SDK to add connected account dashboard functionality to your app using Connect embedded components.

@mludowise-stripe mludowise-stripe changed the title Mludowise/mxmobile 2496 connect package configs [🚫 DO NOT MERGE] [Connect] Prepare to publish StripeConnect module Sep 23, 2024
@mludowise-stripe mludowise-stripe changed the base branch from master to mludowise/MXMOBILE-2502_uk_connect September 23, 2024 02:57
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from 5fca70e to ca120b7 Compare September 23, 2024 03:12
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2502_uk_connect branch from f759d22 to 289c7a6 Compare September 23, 2024 03:50
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 4 times, most recently from 5bbf80d to 80135ce Compare September 23, 2024 06:30
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2502_uk_connect branch from 1802618 to cf3cbc1 Compare September 23, 2024 21:22
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from 80135ce to dc140d2 Compare September 24, 2024 01:04
Base automatically changed from mludowise/MXMOBILE-2502_uk_connect to master September 24, 2024 03:12
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 7ee34cb to 00d6102 Compare September 26, 2024 06:32
@mludowise-stripe mludowise-stripe changed the base branch from master to mludowise/MXMOBILE-2503_notification_banner September 26, 2024 06:35
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 8a68f14 to 60a910a Compare September 26, 2024 22:45
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2503_notification_banner branch 3 times, most recently from baf7731 to c04f948 Compare September 29, 2024 00:18
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 97bb385 to df4771b Compare September 29, 2024 00:36
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2503_notification_banner branch from 6f39d37 to 19b7736 Compare October 2, 2024 19:37
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from df4771b to 60a80a3 Compare October 3, 2024 03:07
Copy link

emerge-tools bot commented Oct 3, 2024

7 builds had no size change, 1 build errored

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.1 MB ⬆️ 3 B 6.9 MB - N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.2 MB - 4.2 MB - N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬆️ 2 B 6.4 MB - N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.7 MB ⬇️ 2 B 11.0 MB - N/A
StripeIdentitySize
com.stripe.StripeIdentitySize
1.0 (1) 1.3 MB ⬇️ 4 B 4.3 MB - N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 466.3 kB - 1.6 MB - N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.4 MB ⬇️ 1 B 4.4 MB - N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

No changes to report

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

No changes to report

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

No changes to report

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

No changes to report

StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize

No changes to report

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

No changes to report

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

No changes to report

Unsuccessful Builds

Name Message
StripeConnectSize
com.stripe.StripeConnectSize
The diff could not be determined because no build for 59e53e7 was uploaded

🛸 Powered by Emerge Tools

Copy link

github-actions bot commented Oct 3, 2024

🚨 New dead code detected in this PR:

ConnectWebView.swift: warning: Function 'showErrorAlert(for:)' is unused
ConnectWebView.swift: warning: Function 'download(decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish()' is unused
ConnectWebView.swift: warning: Function 'download(_:decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(_:didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish(_:)' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2503_notification_banner branch from 0c10880 to bb8a81d Compare October 4, 2024 21:29
Base automatically changed from mludowise/MXMOBILE-2503_notification_banner to master October 4, 2024 22:51
@nschris-stripe nschris-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 3 times, most recently from 080b316 to b7cb344 Compare November 22, 2024 03:02
@mludowise-stripe mludowise-stripe changed the title [🚫 DO NOT MERGE] [Connect] Prepare to publish StripeConnect module [Connect] Prepare to publish StripeConnect module Dec 12, 2024
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 0c8a7f4 to ddfcff1 Compare December 16, 2024 19:30
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from ddfcff1 to 5bde8d8 Compare December 16, 2024 21:41
@mludowise-stripe mludowise-stripe marked this pull request as ready for review December 16, 2024 21:50
@mludowise-stripe mludowise-stripe requested review from a team as code owners December 16, 2024 21:50
nschris-stripe
nschris-stripe previously approved these changes Dec 16, 2024
Copy link

emerge-tools bot commented Dec 16, 2024

📸 Snapshot Test

Base build not found

No build was found for the base commit 59e53e7. This is required to generate a snapshot diff for your pull request.

It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve.


🛸 Powered by Emerge Tools

@mludowise-stripe
Copy link
Collaborator Author

📸 Snapshot Test

Base build not found

No build was found for the base commit 59e53e7. This is required to generate a snapshot diff for your pull request.

It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve.

🛸 Powered by Emerge Tools

This is an expected failure because there were no previous builds of StripeConnect for Emerge to compare the size against

nschris-stripe
nschris-stripe previously approved these changes Dec 16, 2024
Comment on lines +25 to +26
<key>NSCameraUsageDescription</key>
<string>camera description</string>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect assertion fails if the app doesn't configure this, so this has been added to all installation test projects

@mludowise-stripe mludowise-stripe merged commit 1d5020c into master Dec 17, 2024
5 of 7 checks passed
@mludowise-stripe mludowise-stripe deleted the mludowise/MXMOBILE-2496_connect_package_configs branch December 17, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants