Link v3: Connect passthrough mode #4219
Conversation
| case .withPaymentDetails(let linkAccount, let paymentDetails): | ||
| // shouldSave is false, as we don't show a save checkbox in the Link VC | ||
| confirmWithPaymentDetails(linkAccount, paymentDetails, paymentDetails.cvc, false) | ||
| let shouldSave = false // always false, as we don't show a save-to-merchant checkbox in Link VC | ||
|
|
||
| if elementsSession.linkPassthroughModeEnabled { | ||
| linkAccount.sharePaymentDetails(id: paymentDetails.stripeID, cvc: paymentDetails.cvc) { result in | ||
| switch result { |
There was a problem hiding this comment.
Seems like we should add a test to validate that these functions are being called when linkPassthroughModeEnabled == true.
davidme-stripe
dismissed
wooj-stripe’s stale review
The base branch was changed.
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
1 build increased size, 4 builds decreased size, 1 build had no size change
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| 🗑 StripePayments.LinkConsumerIncentive | ⬇️ -3.0 kB |
| DYLD.Exports | ⬇️ -800 B |
| Other | ⬇️ -393 B |
View Treemap
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 56 B
Total download size change: ⬆️ 520 B (0.04%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripeFinancialConnections.FinancialConnectionsAPIClient.encodeAs... | ⬇️ -572 B |
| Other | ⬆️ 628 B |
View Treemap
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 8.3 kB (-0.2%)
Total download size change: ⬇️ 1.7 kB (-0.14%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripePayments.LinkConsumerIncentive | ⬇️ -3.0 kB |
| DYLD.Exports | ⬇️ -752 B |
| Other | ⬇️ -4.6 kB |
View Treemap
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 4.6 kB (-0.07%)
Total download size change: ⬇️ 1.4 kB (-0.07%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripePayments.LinkConsumerIncentive | ⬇️ -3.0 kB |
| DYLD.Exports | ⬇️ -800 B |
| Other | ⬇️ -817 B |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 8.8 kB (-0.08%)
Total download size change: ⬇️ 3.2 kB (-0.09%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripePayments.LinkConsumerIncentive | ⬇️ -3.0 kB |
| StripePaymentSheet.PaymentSheetLinkAccount.sharePaymentDetails(id... | ⬆️ 1.2 kB |
| DYLD.Exports | ⬇️ -1.1 kB |
| 🗑 StripePaymentSheet.TextFieldElement.CensoredCVCConfiguration | ⬇️ -968 B |
| 🗑 StripePaymentSheet.UpdateCardViewController.expiryDateElement | ⬇️ -728 B |
View Treemap
🛸 Powered by Emerge Tools
davidme-stripe
force-pushed
the
relink/passthrough
branch
from
c0c2b98 to
56815ef
Compare
| completion: { _, _ in | ||
| exp.fulfill() | ||
| } |
There was a problem hiding this comment.
Seems like we should do some asserting here? e.g. ensure it has been completed?
There was a problem hiding this comment.
We do, see the "confirm completed" expectation defined above. Additionally, each of the above stubs have their own expectations.
Summary
If passthrough mode is enabled, call the
/shareendpoint to get the passthrough PM, then confirm using that PM.Motivation
Enable passthrough mode in native Link.
Testing
In PaymentSheet Example.
Changelog
None