Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removal dialog showing incorrect brand #4229

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix removal dialog showing incorrect brand #4229

merged 1 commit into from
Nov 6, 2024

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Nov 6, 2024 •
edited
Loading

Summary

  • When a co-branded card does not have a preferred brand set, we should fall back to the display brand not the brand.

Motivation

  • Bug fix

Testing

  • Manual
  • New unit test

Changelog

See diff

@porter-stripe porter-stripe marked this pull request as ready for review November 6, 2024 00:45
@porter-stripe porter-stripe requested review from a team as code owners November 6, 2024 00:45
@porter-stripe porter-stripe enabled auto-merge (squash) November 6, 2024 01:03
@porter-stripe porter-stripe mentioned this pull request Nov 6, 2024
Closed
@porter-stripe porter-stripe merged commit 173e7c2 into master Nov 6, 2024
6 checks passed
@porter-stripe porter-stripe deleted the porter/cbc-removal-fix branch November 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooj-stripe wooj-stripe wooj-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porter-stripe @wooj-stripe