traitCollectionDidChange loading indicator #4928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -73,6 +73,14 @@ class LoadingViewController: UIViewController, BottomSheetContentViewController | |||
| ]) | |||
| activityIndicator.startAnimating() | |||
| } | |||
|
|
|||
| #if !canImport(CompositorServices) | |||
There was a problem hiding this comment.
I'm assuming this is to block vision OS? I believe we can now use #if !os(visionOS) since our minimum Xcode version supports this. Somewhere there was a comment about this that I can't find now. Maybe @davidme-stripe could confirm. Probably a good idea to clean up all of the #if !canImport(CompositorServices) uses to stop us from accidentally propagating this hack.
| @@ -73,6 +73,14 @@ class LoadingViewController: UIViewController, BottomSheetContentViewController | |||
| ]) | |||
| activityIndicator.startAnimating() | |||
| } | |||
|
|
|||
| #if !canImport(CompositorServices) | |||
| public override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) { | |||
There was a problem hiding this comment.
FYI looks like this is deprecated after iOS 17 https://developer.apple.com/documentation/uikit/uitraitenvironment/traitcollectiondidchange(_:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The loading indicator color used to be based off of the system mode (light or dark) instead of the component color, and it wouldn't change its color in response to an appearance change. Now we use traitCollectionDidChange to calculate the correct color and change it when necessary.
Motivation
MOBILESDK-3426
Testing
Before
ScreenRecording_04-04-2025.11-12-05_1.MP4
After
Simulator.Screen.Recording.-.iPhone.16.-.2025-05-22.at.20.34.18.mp4
Changelog
N/A