Add custom footer view support #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom footer view support
Add custom footer view suport
…well as STPPaymentMethodsViewController
…rfman-custom-footer
Rename to StripViewControllerFooterView to make sure protocol won't collide with anyone else's method name. Recalc size of footer and re-set it on viewDidLayoutSubviews in case width changed. Specifically name the pay context version so that its clear it only appies to payment methods VC.
Remove the footer view supporting protocol because it didn't end up being that useful in the end. Specifically separate out footer view properties for add card VC and payment methods VC. Make sure if you set the prop before the view even loads we defer trying to attach it to the table view until the table exists and is sized correctly using viewWillAppear promise.
|
Re-r with newest commit @bg-stripe ? |
bg-stripe
approved these changes
Oct 16, 2017
mludowise-stripe
added a commit
that referenced
this pull request
Mar 2, 2022
Optimizes the DocumentScanner to only perform up to 2 concurrent scan requests at a time, forcing the `AVCaptureSession` delegate to drop frames when the scanner is busy processing images and blocking the video capture thread. On most devices, the ideal maximum number of concurrent scan requests is 2 so we can take advantage of parallelizing processing across both the CPU and GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from #767
Adds the ability to provide a custom footer view that will be added to the view controllers managed by the Stripe SDK.