Add Masterpass to STPSourceParams, allowing Sources to be created #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & transaction ID
…on id and publishable key These are not re-usable, so you need to provide new values every time the test is run. I wish I had a better testing story here, but this is what we've come up with so far.
This moves the hardcoded test for VCO out of a private branch I had, and at least puts it into master, even if it's disabled. The other test basically just ensures that dictionaries work correctly, but it'll also hopefully help guard against unintentionally breaking the format of the payload.
joeydong-stripe
approved these changes
Apr 17, 2018
| NSDictionary *sourceMasterpass = sourceCard[@"masterpass"]; | ||
| XCTAssertNotNil(sourceMasterpass); | ||
| XCTAssertEqualObjects(sourceMasterpass[@"cart_id"], @"12345678"); | ||
| XCTAssertEqualObjects(sourceMasterpass[@"transaction_id"], @"87654321"); |
There was a problem hiding this comment.
I wonder if we can be even more strict here and compare the dictionary as a whole:
XCTAssertEqualObjects(params.additionalAPIParameters, @{@"card": {
@"masterpass": { ... }
}
})
There was a problem hiding this comment.
I suspect we'll get better assertion failures by flattening it out like this. I was also cribbing off testCardParamsWithCard above
danj-stripe
added a commit
that referenced
this pull request
Apr 24, 2018
…v0.9.2 v0.9.2 seems to add some anchor tags for Protocols & Categories, otherwise I just see the new content from #928 and then new version numbers and dates.
csabol-stripe
pushed a commit
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
STPSourceParamsconstructor, which creates necessary params to create acard source using the Masterpass
cartIdandtransactionIdMotivation
Allowing integration with Masterpass SDK. Client apps must handle all of the integration
with the Masterpass SDK. However, once they've done that, a successful
MCCCheckoutResponsereturned by that framework will be populated with thecartIdandtransactionIdnecessary to integrate with Stripe.see also stripe/stripe-android#549
Testing
Basic unit test + manually running a functional test. Larry and I worked together to
generate cartId + transactionId, and ran them through the functional test.
Successfully created
src_1CI1AkDAu10Yox5RoAvqOE9UI've also slightly improved the VCO (#889) tests to reach parity