-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bitcoin source support #931
Conversation
239999d
to
1443eff
Compare
1443eff
to
6eaf8bf
Compare
51bac3d
to
702fee0
Compare
702fee0
to
e53d570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -1,3 +1,4 @@ | |||
// Source: https://stripe.com/docs/sources/ideal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK comments are illegal in JSON, so I think this should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😉 I added this feature a long time ago to the STPTestUtils
: e27d40d#diff-048bbc1b680ccc6bc67023bfe39032b4R44
This procedure does still break if comments are inline with JSON. Also seems like STPTestUtils
and STPFixtures
should be combined eventually.
createBitcoinParams
. Please use a different payment method.