Adjust keyboard avoiding behavior #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop adjusting `scrollView.contentOffset` and let the system natively scroll because of the `scrollView.contentInset` change
|
👍 lgtm (only tested on iPhone 7 iOS 11 though) |
csabol-stripe
approved these changes
May 24, 2018
|
Verified similar behavior on iOS 10 and iOS 9. |
joeydong-stripe
force-pushed
the
joeydong/keyboardcontentinset
branch
from
9d802d7 to
6e3a943
Compare
jaimepark-stripe
pushed a commit
that referenced
this pull request
Apr 11, 2022
Attempts to fix recurring flaky snapshot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stop adjusting
scrollView.contentOffsetand let the system natively scroll because of thescrollView.contentInsetchange. This will scroll the minimum amount until the text field is visible. Previously, we would scroll until the text field is vertically centered on screen.Testing
Did some basic testing with iPhone SE 11.2 Portrait + Landscape Simulator but we should do additional testing on other configurations since I don't have a confident understanding of how
UIViewController+Stripe_KeyboardAvoidingworks.#942