Fix invalid JSON error when deleting Card from Customer #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This did not have a functional impact on the testing, but it sure was misleading while reading through the code.
Some of the Stripe APIs, notably https://stripe.com/docs/api#delete_card return an almost empty object. The parsing code needs to be able to parse an object out of the response, otherwise it considers it failed. This is an object that should be parseable from any successful response. It's pretty useless otherwise.
…rUsingKey:completion:` When deleting a `Card`, the returned JSON does not have all the required fields for a `STPCard` - it only has `id` and `deleted`. When deleting/detaching a `Source`, the returned JSON *is* a decodable `Source` (and does not have a `deleted` field). Using `STPGenericStripeObject` as the deserializer, because it's the only thing that'll work for this method. We cannot use multiple deserializers, because the parsing code relies on the `object` field to pick the correct deserializer, and deleted Cards don't have an `object`. Since the `STPGenericStripeObject` is *not* interesting (the caller already has the id, it was the first argument to this method), just using `STPErrorBlock` as the completion.
|
cc @bg-stripe: thanks for chatting about this. |
csabol-stripe
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use the same code path to delete/detach Card + Source + any
STPSourceProtocolfroma Customer. Depending on the type of the object, the response varies, but the only field
that the response always has is
id.This updates the private
STPAPI deleteSource:fromCustomerUsingKey:completion:methodto use a new class,
STPGenericStripeObject, as the deserializer. Now the SDK doesn'tincorrectly report failures.
Motivation
IOS-798
Testing
Minor updates to the tests, but this was best tested manually in the Standard Integration.
CheckoutViewController.init, changeconfig.createCardSourcestofalse.[STPPaymentMethodsInternalViewController tableView:commitEditingStyle:forRowAtIndexPath:],add a completion block to the
[self.apiAdapter detachSourceFromCustomer:completion:]call.I chose to log the error, but you could also set a breakpoint and inspect it.
We don't have an automated way to create customers & attach sources, because that requires
a secret key.
We also don't have an existing test pattern to mock network responses to
STPAPIClient.