Add back IdempotencyException and add a test (#1881)

stripe · Sep 28, 2024 · dc082a2 · dc082a2
1 parent 5cd2f1b
commit dc082a2
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 6 deletions.
diff --git a/src/main/java/com/stripe/exception/IdempotencyException.java b/src/main/java/com/stripe/exception/IdempotencyException.java
@@ -0,0 +1,9 @@
+package com.stripe.exception;
+
+public class IdempotencyException extends StripeException {
+  private static final long serialVersionUID = 2L;
+
+  public IdempotencyException(String message, String requestId, String code, Integer statusCode) {
+    super(message, requestId, code, statusCode);
+  }
+}
diff --git a/src/main/java/com/stripe/net/LiveStripeResponseGetter.java b/src/main/java/com/stripe/net/LiveStripeResponseGetter.java
@@ -320,12 +320,8 @@ private void handleV1ApiError(StripeResponse response) throws StripeException {
       case 404:
         if ("idempotency_error".equals(error.getType())) {
           exception =
-              StripeException.parseV2Exception(
-                  "idempotency_error",
-                  ApiResource.GSON.fromJson(response.body(), JsonObject.class),
-                  response.code(),
-                  response.requestId(),
-                  this);
+              new IdempotencyException(
+                  error.getMessage(), response.requestId(), error.getCode(), response.code());
         } else {
           exception =
               new InvalidRequestException(

diff --git a/src/test/java/com/stripe/functional/LiveStripeResponseGetterTest.java b/src/test/java/com/stripe/functional/LiveStripeResponseGetterTest.java
@@ -7,6 +7,7 @@
 import com.google.gson.JsonSyntaxException;
 import com.stripe.BaseStripeTest;
 import com.stripe.exception.ApiException;
+import com.stripe.exception.IdempotencyException;
 import com.stripe.exception.StripeException;
 import com.stripe.model.Subscription;
 import com.stripe.net.ApiResource;
@@ -42,4 +43,24 @@ public void testInvalidJson() throws StripeException {
     assertNotNull(exception.getCause());
     assertThat(exception.getCause(), CoreMatchers.instanceOf(JsonSyntaxException.class));
   }
+
+  @Test
+  public void testIdempotencyError() throws StripeException {
+    HttpClient spy = Mockito.spy(new HttpURLConnectionClient());
+    StripeResponseGetter srg = new LiveStripeResponseGetter(spy);
+    ApiResource.setGlobalResponseGetter(srg);
+    StripeResponse response =
+        new StripeResponse(
+            400,
+            HttpHeaders.of(Collections.emptyMap()),
+            "{\"error\": {\"message\": \"idempotency\", \"type\": \"idempotency_error\"}}");
+    Mockito.doReturn(response).when(spy).requestWithRetries(Mockito.<StripeRequest>any());
+    Exception exception =
+        assertThrows(
+            IdempotencyException.class,
+            () -> {
+              Subscription.retrieve("sub_123");
+            });
+    assertThat(exception.getMessage(), CoreMatchers.containsString("idempotency"));
+  }
 }