API Updates #1201
Merged
API Updates #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
May 5, 2021
| @@ -456,12 +456,20 @@ public LineItemCollection listLineItems(SessionListLineItemsParams params, Reque | |||
| @EqualsAndHashCode(callSuper = false) | |||
| public static class PaymentMethodOptions extends StripeObject { | |||
| @SerializedName("acss_debit") | |||
| AcssDebit acssDebit; | |||
| CheckoutAcssDebitPaymentMethodOptions acssDebit; | |||
There was a problem hiding this comment.
That is a breaking change.
There was a problem hiding this comment.
oh wow, nice
remi-stripe
reviewed
May 5, 2021
| @@ -18,7 +18,6 @@ | |||
| factories.add(new BalanceTransactionSourceTypeAdapterFactory()); | |||
| factories.add(new ExternalAccountTypeAdapterFactory()); | |||
| factories.add(new PaymentSourceTypeAdapterFactory()); | |||
| factories.add(new ReflectionCheckingTypeAdapterFactory()); | |||
| } | |||
There was a problem hiding this comment.
This came in on #1197, I think I need to rebase this PR off a different master. (nope, need to add this change to codegen)
richardm-stripe
force-pushed
the
latest-codegen
branch
from
f037f20
to
d3f51ad
Compare
richardm-stripe
force-pushed
the
latest-codegen
branch
from
cd59bf0
to
2428114
Compare
remi-stripe
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 7cc2037.
r? @richardm-stripe
cc @stripe/api-libraries
Changelog
card_presentonPaymentIntent.payment_method_optionsdefault_incompleteas apayment_behavioronSubscriptionItemCreateParams,SubscriptionUpdateParams, andSubscriptionCreateParams.single_member_llcas astructureonAccountCreateParams.companyandAccountUpdateParams.company.