-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master
into search-beta
#1276
Merged
richardm-stripe
merged 28 commits into
search-beta
from
richardm-search-beta-merge-master
Oct 27, 2021
Merged
Merge master
into search-beta
#1276
richardm-stripe
merged 28 commits into
search-beta
from
richardm-search-beta-merge-master
Oct 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Codegen for openapi 95a1ab8
* Codegen for openapi 00eec38
master
into search-beta
dcr-stripe
reviewed
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG overall, just one question!
PTAL @richardm-stripe
@@ -1,255 +1,21 @@ | |||
# Stripe Java client library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the installation section but for the beta?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify
r? @stripe/api-library-reviewers
Summary
Mostly this just merges the latest
master
intosearch-beta
in preparation for releasingsearch-beta
again, but I included three other substantive changes:63e35dc - I replaced the README.md with one specific to the beta library. This is what we did for
stripe-node
.37d3d4d - I reverted the version back to
20.75.0
. When I run the script to release the beta, this will bump the version appropriately.d783e33 - I removed the "documentation test" which makes assumptions that aren't appropriate to the beta branch.
I'm not sure this is really the best flow to follow for these beta library updates, especially once automation is further along... but it should work for now.