Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into search-beta #1276

Merged
merged 28 commits into from
Oct 27, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Oct 27, 2021

Notify

r? @stripe/api-library-reviewers

Summary

Mostly this just merges the latest master into search-beta in preparation for releasing search-beta again, but I included three other substantive changes:

  • 63e35dc - I replaced the README.md with one specific to the beta library. This is what we did for stripe-node.

  • 37d3d4d - I reverted the version back to 20.75.0. When I run the script to release the beta, this will bump the version appropriately.

  • d783e33 - I removed the "documentation test" which makes assumptions that aren't appropriate to the beta branch.

I'm not sure this is really the best flow to follow for these beta library updates, especially once automation is further along... but it should work for now.

@richardm-stripe richardm-stripe changed the title Richardm search beta merge master Merge master into search-beta Oct 27, 2021
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall, just one question!

PTAL @richardm-stripe

@@ -1,255 +1,21 @@
# Stripe Java client library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the installation section but for the beta?

@richardm-stripe richardm-stripe merged commit d17ef6e into search-beta Oct 27, 2021
@richardm-stripe richardm-stripe deleted the richardm-search-beta-merge-master branch October 27, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants