Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add getConnectBase #1882

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Re-add getConnectBase #1882

merged 1 commit into from
Sep 28, 2024

Conversation

helenye-stripe
Copy link
Contributor

This was accidentally removed.

xavdid-stripe
xavdid-stripe approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@xavdid-stripe xavdid-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix, but curious why didn't any CI go off to warn us this got removed

@helenye-stripe
Copy link
Contributor Author

helenye-stripe commented Sep 28, 2024 •
edited
Loading

I think it did, but the Event -> MeterEvent PR also broke a bunch of other compat and I missed it.

@helenye-stripe helenye-stripe merged commit 4e58dcc into sdk-release/next-major Sep 28, 2024
12 checks passed
@helenye-stripe helenye-stripe deleted the helenye-connect branch September 28, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid-stripe xavdid-stripe xavdid-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helenye-stripe @xavdid-stripe