Merge from master to beta #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar-stripe
reviewed
Oct 3, 2024
ramya-stripe
force-pushed
the
ramya/merge-beta
branch
from
bcfdbdd to
8d66ab6
Compare
jar-stripe
reviewed
Oct 3, 2024
| @@ -394,7 +394,7 @@ protected static String normalizeClientId(String clientId) { | |||
| } | |||
|
|
|||
| protected static String normalizeStripeVersion(String stripeVersion) { | |||
| // null stripeVersions are considered "valid" and use Stripe.stripeVersion | |||
| // null stripeVersions are considered "valid" and use Stripe.apiVersion | |||
There was a problem hiding this comment.
Shouldn't it be Stripe.stripeVersion?
There was a problem hiding this comment.
You are right. I assumed what was in master to be the source of truth - didnt check the actual property name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been more changes in the master branch since the last time we merged from it to beta. Doing on last merge from master before this week's beta releases