Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tolerance argument to parseThinEvent #1912

Merged
merged 1 commit into from
Oct 28, 2024
Merged

add tolerance argument to parseThinEvent #1912

merged 1 commit into from
Oct 28, 2024

Conversation

xavdid-stripe
Copy link
Member

@xavdid-stripe xavdid-stripe commented Oct 28, 2024 •
edited
Loading

Why

Other SDKs can set a custom tolerance when parsing thin events, but Java couldn't- this rectifies that

What

  • adds additional parseThinEvent with a tolerance argument, plus docs.

See Also

Changelog

  • The default tolerance value is still what most users will want, but this fixes an oversight where it wasn't possible to set tolerance at all when parsing thin events

@xavdid-stripe xavdid-stripe enabled auto-merge (squash) October 28, 2024 21:21
@xavdid-stripe xavdid-stripe merged commit c33965d into master Oct 28, 2024
12 checks passed
@xavdid-stripe xavdid-stripe deleted the DEVSDK-2143 branch October 28, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenye-stripe helenye-stripe helenye-stripe approved these changes

@jar-stripe jar-stripe Awaiting requested review from jar-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavdid-stripe @helenye-stripe