Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish docker image to docker hub? #49

Closed
mmmmmrob opened this issue Mar 21, 2018 · 1 comment
Closed

Publish docker image to docker hub? #49

mmmmmrob opened this issue Mar 21, 2018 · 1 comment

Comments

@mmmmmrob
Copy link

Is there an official build of the docker image that can be used without building? I couldn't find one on docker hub.
brandur-stripe pushed a commit that referenced this issue Mar 21, 2018
@brandur
Push Docker image to Docker Hub
5f62bf7 
Pushes the built Docker image to Docker Hub as part of a Travis deploy
step. This allows Docker users to access the image more easily.

There are a few caveats with this implementation:

1. We're only building `master`. If this ends up being something we use,
   we should build tagged version images as well.

2. It pushes to `stripemock/stripe-mock` instead of `stripe/stripe-mock`
   because we're having a little trouble getting the collaboration
   privileges worked out on Docker Hub's Stripe organization right now.
   We should change it to `stripe/stripe-mock` when possible.

Fixes #49.
@brandur-stripe brandur-stripe mentioned this issue Mar 21, 2018
Merged
brandur-stripe pushed a commit that referenced this issue Mar 21, 2018
@brandur
Push Docker image to Docker Hub
0781111 
Pushes the built Docker image to Docker Hub as part of a Travis deploy
step. This allows Docker users to access the image more easily.

There are a few caveats with this implementation:

1. We're only building `master`. If this ends up being something we use,
   we should build tagged version images as well.

2. It pushes to `stripemock/stripe-mock` instead of `stripe/stripe-mock`
   because we're having a little trouble getting the collaboration
   privileges worked out on Docker Hub's Stripe organization right now.
   We should change it to `stripe/stripe-mock` when possible.

Fixes #49.
@brandur
Copy link
Contributor

brandur commented Mar 21, 2018

I added #50 to push an image to Docker Hub based off the master branch (we might do tagged images at some point in the future too, but we'll do the easy thing for now).

A couple caveats:

  1. For now this is being built to https://hub.docker.com/r/stripemock/stripe-mock/, but we'll probably move the repository shortly to stripe/stripe-mock, so keep an eye out for that.
  2. The image is large (~91 MB) right now. Leaner Docker image through the use of multi-stage builds #51 should be coming in soon, which will lean it out quite a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandur @mmmmmrob