Replace data in response with data from request #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we try to to some additional enrichment on response data by replacing what we found in fixtures with data that came in from the request. The algorithm is quite simple: we walk the decoded request object and the generated response object, replace any scalars that we see where the key name is the same, and recurse in when we see two keys with the same names that are both maps. In addition, I realized that we are no longer vetting that incorrect keys are not being passed to stripe-mock, which appears to be a regression from a change passed some time ago. This patch also adds back a check on `additionalProperties: false`.
|
👍 in general, but I think we should look at the response schema type when deciding whether or not to replace data, in addition to or instead of looking at the fixture data type. |
|
@tmaxwell-stripe Thanks Tim! And yes, totally agreed. With this framework in place, I'm going to add that on as the next incremental step. |
|
Alright, going to pull this in for now, and keep iterating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we try to to some additional enrichment on response data by
replacing what we found in fixtures with data that came in from the
request.
The algorithm is quite simple: we walk the decoded request object and
the generated response object, replace any scalars that we see where the
key name is the same, and recurse in when we see two keys with the same
names that are both maps.
In addition, I realized that we are no longer vetting that incorrect
keys are not being passed to stripe-mock, which appears to be a
regression from a change passed some time ago. This patch also adds back
a check on
additionalProperties: false.cc @tmaxwell-stripe Any thoughts on this?
cc @stripe/api-libraries