Add option to activate HTTPS and HTTP/2 if client supports it #82
+191
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `-https` command line option to stripe-mock. When enabled, it comes up serving HTTPS using a self-signed certificate that's bundled into the executable. Go supports serving HTTP/2 almost automatically from `net/http` with HTTPS is activated, so clients that support HTTP/2 can test with it with stripe-mock. The server will fallback to HTTP automatically for clients that don't. I figure this will be handy testing HTTP/2 support in our various client libraries because it's easy to have stripe-mock spit out debug lines that tell us that HTTP/2 has been activated correctly.
|
Here's a little program that shows how this might be used with stripe-go: package main
import (
"crypto/tls"
"fmt"
"net/http"
stripe "github.com/stripe/stripe-go"
"github.com/stripe/stripe-go/customer"
"golang.org/x/net/http2"
)
func main() {
stripe.Key = "sk_test_123"
transport := &http.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true,
},
}
err := http2.ConfigureTransport(transport)
if err != nil {
panic(err)
}
httpClient := &http.Client{
Transport: transport,
}
stripeMockBackend := stripe.GetBackendWithConfig(
stripe.APIBackend,
&stripe.BackendConfig{
URL: "https://localhost:12112",
HTTPClient: httpClient,
Logger: stripe.Logger,
},
)
stripe.SetBackend(stripe.APIBackend, stripeMockBackend)
stripe.SetBackend(stripe.UploadsBackend, stripeMockBackend)
c, err := customer.Get("cus_DDHV5EAh4nMeEf", nil)
fmt.Printf("customer = %+v\n", c)
fmt.Printf("err = %+v\n", err)
}And the output from a run: And stripe-mock's output: |
|
Thanks OB! |
|
Released as v0.20.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
-httpscommand line option to stripe-mock. Whenenabled, it comes up serving HTTPS using a self-signed certificate
that's bundled into the executable.
Go supports serving HTTP/2 almost automatically from
net/httpwithHTTPS is activated, so clients that support HTTP/2 can test with it with
stripe-mock. The server will fallback to HTTP automatically for clients
that don't.
I figure this will be handy testing HTTP/2 support in our various client
libraries because it's easy to have stripe-mock spit out debug lines
that tell us that HTTP/2 has been activated correctly.
r? @ob-stripe
cc @stripe/api-libraries