Make branch name configurable in update-openapi-spec #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le step, to let us specify a feature branch to update from (for testing)" This reverts commit beb9a01.
|
Dont merge until we resolve stripe/openapi#157 (comment) |
|
This one is fine but I think we'll get this one for free when stripe/openapi#157 is merged. Bots will make the PR from that (B) to this (C) and make the same changes. So i'd hold off here for now to make sure this works the way we think it does. Otherwise, ✅ |
jar-stripe
changed the title
xavdid-stripe
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When working on stripe/openapi#157, it was convenient to be able to specify the branch name to pull from in the update step. This let me test the changes end to end before merging the PRs. This PR makes this configurability official.
What?