Improve args check to support optional params for makeRequest (#827)

stripe · Mar 6, 2020 · 461d67b · 461d67b
1 parent 8042dcd
commit 461d67b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/makeRequest.js b/lib/makeRequest.js
@@ -33,7 +33,7 @@ function getRequestOpts(self, requestArgs, spec, overrideData) {
   const options = utils.getOptionsFromArgs(args);
 
   // Validate that there are no more args.
-  if (args.length) {
+  if (args.filter((x) => x != null).length) {
     throw new Error(
       `Stripe: Unknown arguments (${args}). Did you mean to pass an options object? See https://github.com/stripe/stripe-node/wiki/Passing-Options. (on API request to ${requestMethod} \`${path}\`)`
     );

diff --git a/test/StripeResource.spec.js b/test/StripeResource.spec.js
@@ -77,6 +77,28 @@ describe('StripeResource', () => {
         });
       });
 
+      it('works correctly with undefined optional arguments', (done) => {
+        const scope = nock(`https://${stripe.getConstant('DEFAULT_HOST')}`)
+          .get('/v1/accounts/acct_123')
+          .reply(200, '{}');
+
+        realStripe.accounts.retrieve('acct_123', undefined, (err, response) => {
+          done(err);
+          scope.done();
+        });
+      });
+
+      it('works correctly with null optional arguments', (done) => {
+        const scope = nock(`https://${stripe.getConstant('DEFAULT_HOST')}`)
+          .get('/v1/accounts/acct_123')
+          .reply(200, '{}');
+
+        realStripe.accounts.retrieve('acct_123', null, (err, response) => {
+          done(err);
+          scope.done();
+        });
+      });
+
       it('encodes data for DELETE requests as query params', (done) => {
         const data = {
           foo: 'bar',