Use arrows in more places

stripe · May 8, 2019 · 6f2dcb6 · 6f2dcb6
1 parent 579060e
commit 6f2dcb6
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 35 deletions.
diff --git a/lib/Webhooks.js b/lib/Webhooks.js
@@ -25,7 +25,7 @@ const Webhook = {
 const signature = {
   EXPECTED_SCHEME: 'v1',
 
-  _computeSignature(payload, secret) {
+  _computeSignature: (payload, secret) => {
     return crypto
       .createHmac('sha256', secret)
       .update(payload, 'utf8')

diff --git a/lib/autoPagination.js b/lib/autoPagination.js
@@ -38,12 +38,12 @@ function makeAutoPaginationMethods(self, requestArgs, spec, firstPagePromise) {
   }
 
   function asyncIteratorNext() {
-    return memoizedPromise(promiseCache, (resolve, reject) =>
-      listPromise
+    return memoizedPromise(promiseCache, (resolve, reject) => {
+      return listPromise
         .then(iterate)
         .then(resolve)
-        .catch(reject)
-    );
+        .catch(reject);
+    });
   }
 
   const autoPagingEach = makeAutoPagingEach(asyncIteratorNext);
@@ -55,11 +55,11 @@ function makeAutoPaginationMethods(self, requestArgs, spec, firstPagePromise) {
 
     // Async iterator functions:
     next: asyncIteratorNext,
-    return() {
+    return: () => {
       // This is required for `break`.
       return {};
     },
-    [getAsyncIteratorSymbol()]: function() {
+    [getAsyncIteratorSymbol()]: () => {
       return autoPaginationMethods;
     },
   };

diff --git a/lib/resources/EphemeralKeys.js b/lib/resources/EphemeralKeys.js
@@ -6,7 +6,7 @@ const stripeMethod = StripeResource.method;
 module.exports = StripeResource.extend({
   create: stripeMethod({
     method: 'POST',
-    validator(data, options) {
+    validator: (data, options) => {
       if (!options.headers || !options.headers['Stripe-Version']) {
         throw new Error(
           'stripe_version must be specified to create an ephemeral key'

diff --git a/lib/stripe.js b/lib/stripe.js
@@ -252,7 +252,7 @@ Stripe.prototype = {
     return this._clientId;
   },
 
-  getConstant(c) {
+  getConstant: (c) => {
     return Stripe[c];
   },
 

diff --git a/lib/utils.js b/lib/utils.js
@@ -17,25 +17,23 @@ const OPTIONS_KEYS = [
 ];
 
 const utils = (module.exports = {
-  isAuthKey(key) {
+  isAuthKey: (key) => {
     return typeof key == 'string' && /^(?:[a-z]{2}_)?[A-z0-9]{32}$/.test(key);
   },
 
-  isOptionsHash(o) {
+  isOptionsHash: (o) => {
     return isPlainObject(o) && OPTIONS_KEYS.some((key) => hasOwn.call(o, key));
   },
 
   /**
    * Stringifies an Object, accommodating nested objects
    * (forming the conventional key 'parent[child]=value')
    */
-  stringifyRequestData(data) {
+  stringifyRequestData: (data) => {
     return (
       qs
         .stringify(data, {
-          serializeDate(d) {
-            return Math.floor(d.getTime() / 1000);
-          },
+          serializeDate: (d) => Math.floor(d.getTime() / 1000),
         })
         // Don't use strict form encoding by changing the square bracket control
         // characters back to their literals. This is fine by the server, and
@@ -58,19 +56,20 @@ const utils = (module.exports = {
       '\u2028': '\\u2028',
       '\u2029': '\\u2029',
     };
-    return function makeURLInterpolator(str) {
+    return (str) => {
       const cleanString = str.replace(/["\n\r\u2028\u2029]/g, ($0) => rc[$0]);
-      return (outputs) =>
-        cleanString.replace(/\{([\s\S]+?)\}/g, ($0, $1) =>
+      return (outputs) => {
+        return cleanString.replace(/\{([\s\S]+?)\}/g, ($0, $1) =>
           encodeURIComponent(outputs[$1] || '')
         );
+      };
     };
   })(),
 
   /**
    * Return the data argument from a list of arguments
    */
-  getDataFromArgs(args) {
+  getDataFromArgs: (args) => {
     if (args.length < 1 || !isPlainObject(args[0])) {
       return {};
     }
@@ -106,7 +105,7 @@ const utils = (module.exports = {
   /**
    * Return the options hash from a list of arguments
    */
-  getOptionsFromArgs(args) {
+  getOptionsFromArgs: (args) => {
     const opts = {
       auth: null,
       headers: {},
@@ -171,7 +170,7 @@ const utils = (module.exports = {
   /**
    * Secure compare, from https://github.com/freewil/scmp
    */
-  secureCompare(a, b) {
+  secureCompare: (a, b) => {
     a = Buffer.from(a);
     b = Buffer.from(b);
 
@@ -199,7 +198,7 @@ const utils = (module.exports = {
   /**
    * Remove empty values from an object
    */
-  removeEmpty(obj) {
+  removeEmpty: (obj) => {
     if (typeof obj !== 'object') {
       throw new Error('Argument must be an object');
     }
@@ -217,14 +216,14 @@ const utils = (module.exports = {
    * Determine if file data is a derivative of EventEmitter class.
    * https://nodejs.org/api/events.html#events_events
    */
-  checkForStream(obj) {
+  checkForStream: (obj) => {
     if (obj.file && obj.file.data) {
       return obj.file.data instanceof EventEmitter;
     }
     return false;
   },
 
-  callbackifyPromiseWithTimeout(promise, callback) {
+  callbackifyPromiseWithTimeout: (promise, callback) => {
     if (callback) {
       // Ensure callback is called outside of promise stack.
       return promise.then(
@@ -247,7 +246,7 @@ const utils = (module.exports = {
   /**
    * Allow for special capitalization cases (such as OAuth)
    */
-  pascalToCamelCase(name) {
+  pascalToCamelCase: (name) => {
     if (name === 'OAuth') {
       return 'oauth';
     } else {
@@ -264,7 +263,7 @@ const utils = (module.exports = {
    *
    * This unifies that interface.
    */
-  safeExec: function safeExec(cmd, cb) {
+  safeExec: (cmd, cb) => {
     try {
       utils._exec(cmd, cb);
     } catch (e) {
@@ -275,16 +274,16 @@ const utils = (module.exports = {
   // For mocking in tests.
   _exec: exec,
 
-  isObject: function isObject(obj) {
+  isObject: (obj) => {
     const type = typeof obj;
     return (type === 'function' || type === 'object') && !!obj;
   },
 
   // For use in multipart requests
-  flattenAndStringify: function flattenAndStringify(data) {
+  flattenAndStringify: (data) => {
     const result = {};
 
-    function step(obj, prevKey) {
+    const step = (obj, prevKey) => {
       Object.keys(obj).forEach((key) => {
         const value = obj[key];
 
@@ -303,7 +302,7 @@ const utils = (module.exports = {
           result[newKey] = String(value);
         }
       });
-    }
+    };
 
     step(data);
 

diff --git a/testUtils/index.js b/testUtils/index.js
@@ -9,14 +9,14 @@ require('chai').use(require('chai-as-promised'));
 const ResourceNamespace = require('../lib/ResourceNamespace').ResourceNamespace;
 
 const utils = (module.exports = {
-  getUserStripeKey() {
+  getUserStripeKey: () => {
     const key =
       process.env.STRIPE_TEST_API_KEY || 'tGN0bIwXnHdwOa85VABjPdSn8nWY7G7I';
 
     return key;
   },
 
-  getSpyableStripe() {
+  getSpyableStripe: () => {
     // Provide a testable stripe instance
     // That is, with mock-requests built in and hookable
 
@@ -146,17 +146,17 @@ const utils = (module.exports = {
   /**
    * Get a random string for test Object creation
    */
-  getRandomString() {
+  getRandomString: () => {
     return Math.random()
       .toString(36)
       .slice(2);
   },
 
-  envSupportsForAwait() {
+  envSupportsForAwait: () => {
     return typeof Symbol !== 'undefined' && Symbol.asyncIterator;
   },
 
-  envSupportsAwait() {
+  envSupportsAwait: () => {
     try {
       eval('(async function() {})'); // eslint-disable-line no-eval
       return true;