Typedef for Stripe.StripeResource #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-striperesource-types
branch
from
2a1aca3
to
47463dd
Compare
|
Hey @richardm-stripe! I know I contributed a bunch to these initially but my TypeScript isn't that great; probably better to have someone else with more familiarity review. Sorry! |
paulasjes-stripe
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Looks good, but should we also include MAX_BUFFERED_REQUEST_METRICS since we've listed everything else on the StripeResource object?
|
ptal @paulasjes-stripe |
paulasjes-stripe
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #994
r? @jlomas-stripe
cc @stripe/api-libraries
We considered adding this for #920 but then opted not to, but per #994 this is not convenient for users. We could just expose
anybut why not try and get the types right?The types in this PR are an approximation that reflect mostly the "public interface" of Stripe.StripeResource, and still use
anya great deal, but it's a starting place.