Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on CRULD order for method definitions #1057

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

richardm-stripe
Copy link
Contributor

Summary

In the typescript definitions, the order of methods has always been "create, retrieve, update, list, delete, ...customMethods". This standardizes on that order in the node resource definitions as well

Notify

r? @ctrudeau-stripe
cc @stripe/api-libraries

Copy link
Contributor

@ctrudeau-stripe ctrudeau-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardm-stripe richardm-stripe merged commit d82203b into master Oct 27, 2020
@richardm-stripe richardm-stripe deleted the richardm-standardize-method-ordering branch October 27, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants