make request timeout errors eligible for retry #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrudeau-stripe
approved these changes
Jan 5, 2021
|
similarly this lgtm, though I think we should consider a |
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 14, 2021
chore(deps): bump stripe from 6.36.0 to 8.138.0 in /api-server
Technology-Community/freeCodeCamp#145
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1058
r? @tjfontaine-stripe @ctrudeau-stripe
Presently errors that result from the node http request timeout are not eligible to be retried.
I doubt this is deliberate and it seems like these requests should generally be retried, the same as ECONNRESET or any other sort of connection error.
This is technically a behavior change, so my inclination is to wait until the next major version, since there are a lot of open network-related issues and it would be good to address several of them.