Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript definition for StripeResource.LastResponse.headers #1206

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Jul 28, 2021

Notify

cc @stripe/api-libraries

Summary

Move typescript definition for headers to the correct location.

You can see that they are added to the object that eventually becomes .lastResponse here

Motivation

Fixes #1204

@richardm-stripe richardm-stripe changed the title Richardm fix header typedef Fix Typescript definition for StripeResource.LastResponse.headers Jul 28, 2021
@richardm-stripe
Copy link
Contributor Author

r? @stripe/api-library-reviewers

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @richardm-stripe !

@richardm-stripe richardm-stripe merged commit 69e018c into master Jul 28, 2021
@richardm-stripe richardm-stripe deleted the richardm-fix-header-typedef branch July 28, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripe.Response<Stripe.Charge> does not contain header information
2 participants