Remove DOM type references. #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-loosen-dom-types
branch
from
6a756e8
to
ed7e765
Compare
richardm-stripe
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
Summary
Removes the references to DOM types, specifically the fetch function (and its return/stream types) as well as the SubtleCrypto interface.
Unfortunately this reference pollutes the global namespace for Node packages, which don't include these DOM APIs.
We lose some type-safety here by switching to
anybut the alternative would be copying in the types from the DOM typescript definitions. These are quite substantial (eg. thefetchinput arguments require many types) and would require keeping these types in sync with moving web standards.Motivation
#1326