Update search pagination to use page param instead of next_page. #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-search-page
branch
from
b10abbc
to
7be09fd
Compare
dcr-stripe
changed the title
dcr-stripe
force-pushed
the
dcr-search-page
branch
from
81d36e1
to
d344304
Compare
dcr-stripe
commented
Mar 4, 2022
richardm-stripe
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
Summary
Updates the search pagination behavior to account for two changes:
next_pagerequest parameter has been renamed topage.next_pageresponse property is always provided, but will return null when there is no page. Previously it would not be provided in the return object at all.This is not considered a breaking change as no currently released API uses this object and is thus purely an infrastructural change.