Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1386

Merged
merged 3 commits into from
Mar 29, 2022
Merged

API Updates #1386

merged 3 commits into from
Mar 29, 2022

Conversation

pakrym-stripe
Copy link
Contributor

Codegen for openapi 1700e20.
r? @yejia-stripe
cc @stripe/api-libraries

Changelog

  • Add support for cancel_action, process_payment_intent, process_setup_intent, and set_reader_display methods on resource Terminal.Reader
  • Change Charge.failure_balance_transaction, Invoice.payment_settings.payment_method_options.us_bank_account, PaymentIntent.next_action.verify_with_microdeposits.microdeposit_type, SetupIntent.next_action.verify_with_microdeposits.microdeposit_type, and Subscription.payment_settings.payment_method_options.us_bank_account to be required
  • Add support for action on Terminal.Reader

Copy link
Contributor

@yejia-stripe yejia-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client/type changes lgtm! one comment about the test name


describe('Reader Resource', () => {
describe('retrieve', () => {
it('Sends the correct request', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the test name was copied from the update test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants