Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1442

Merged
merged 2 commits into from
Jun 8, 2022
Merged

API Updates #1442

merged 2 commits into from
Jun 8, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Jun 6, 2022

Codegen for openapi v152.
r? @yejia-stripe
cc @stripe/api-libraries

Changelog

  • Add support for network_details method on resource ReceivedCredits/ReceivedDebits

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Some thoughts on the overall scaffolding for betas:

  1. PR title should be different - this threw me off.
  2. Is OPENAPI_VERSION / the PR description going to be accurate for betas?

@pakrym-stripe
Copy link
Contributor Author

pakrym-stripe commented Jun 8, 2022

Is OPENAPI_VERSION / the PR description going to be accurate for betas?

Automated diff will be wrong by default (I fixed this one) but the PR description and OPENAPI_VERSION are correct. Every tag of openapi repo contains both the stable and beta yamls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants