Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1534

Merged
merged 2 commits into from
Aug 26, 2022
Merged

API Updates #1534

merged 2 commits into from
Aug 26, 2022

Conversation

dcr-stripe
Copy link
Contributor

@dcr-stripe dcr-stripe commented Aug 26, 2022

Codegen for openapi v186.
r? @yejia-stripe
cc @stripe/api-libraries

Changelog

  • Change Account.company.name, Charge.refunds, PaymentIntent.charges, Product.caption, Product.statement_descriptor, Product.unit_label, Terminal.Configuration.tipping.aud.fixed_amounts, Terminal.Configuration.tipping.aud.percentages, Terminal.Configuration.tipping.cad.fixed_amounts, Terminal.Configuration.tipping.cad.percentages, Terminal.Configuration.tipping.chf.fixed_amounts, Terminal.Configuration.tipping.chf.percentages, Terminal.Configuration.tipping.czk.fixed_amounts, Terminal.Configuration.tipping.czk.percentages, Terminal.Configuration.tipping.dkk.fixed_amounts, Terminal.Configuration.tipping.dkk.percentages, Terminal.Configuration.tipping.eur.fixed_amounts, Terminal.Configuration.tipping.eur.percentages, Terminal.Configuration.tipping.gbp.fixed_amounts, Terminal.Configuration.tipping.gbp.percentages, Terminal.Configuration.tipping.hkd.fixed_amounts, Terminal.Configuration.tipping.hkd.percentages, Terminal.Configuration.tipping.myr.fixed_amounts, Terminal.Configuration.tipping.myr.percentages, Terminal.Configuration.tipping.nok.fixed_amounts, Terminal.Configuration.tipping.nok.percentages, Terminal.Configuration.tipping.nzd.fixed_amounts, Terminal.Configuration.tipping.nzd.percentages, Terminal.Configuration.tipping.sek.fixed_amounts, Terminal.Configuration.tipping.sek.percentages, Terminal.Configuration.tipping.sgd.fixed_amounts, Terminal.Configuration.tipping.sgd.percentages, Terminal.Configuration.tipping.usd.fixed_amounts, Terminal.Configuration.tipping.usd.percentages, Treasury.FinancialAccount.active_features, Treasury.FinancialAccount.pending_features, Treasury.FinancialAccount.platform_restrictions, and Treasury.FinancialAccount.restricted_features to be optional
    • This is a bug fix. These fields were all actually optional and not guaranteed to be returned by the Stripe API, however the type annotations did not correctly reflect this.
    • Fixes Remove caption from Product type #1518.
  • Add support for login_page on BillingPortal.Configuration, BillingPortalConfigurationCreateParams, and BillingPortalConfigurationUpdateParams
  • Add support for new value deutsche_bank_ag on enums Charge.payment_method_details.eps.bank, PaymentIntentConfirmParams.payment_method_data.eps.bank, PaymentIntentCreateParams.payment_method_data.eps.bank, PaymentIntentUpdateParams.payment_method_data.eps.bank, PaymentMethod.eps.bank, PaymentMethodCreateParams.eps.bank, SetupIntentConfirmParams.payment_method_data.eps.bank, SetupIntentCreateParams.payment_method_data.eps.bank, and SetupIntentUpdateParams.payment_method_data.eps.bank
  • Add support for customs and phone_number on Issuing.Card.shipping and IssuingCardCreateParams.shipping
  • Add support for description on Quote.subscription_data, QuoteCreateParams.subscription_data, QuoteUpdateParams.subscription_data, SubscriptionSchedule.default_settings, SubscriptionSchedule.phases[], SubscriptionScheduleCreateParams.default_settings, SubscriptionScheduleCreateParams.phases[], SubscriptionScheduleUpdateParams.default_settings, and SubscriptionScheduleUpdateParams.phases[]

Copy link
Contributor

@yejia-stripe yejia-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but would we shorten the changelog?

@stripe-ci stripe-ci assigned dcr-stripe and unassigned yejia-stripe Aug 26, 2022
@dcr-stripe
Copy link
Contributor Author

lgtm but would we shorten the changelog?

Good question - I think here it's good to be exhaustive since it's a bug fix that impacts a number of fields, but I added a bit more detail to the changelog to give information on why we made this change.

@dcr-stripe dcr-stripe merged commit 51ff04e into master Aug 26, 2022
@dcr-stripe dcr-stripe deleted the latest-codegen-master branch August 26, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove caption from Product type
2 participants