use native UUID method if available #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I pushed a commit and wrote one of the tests you described |
richardm-stripe
force-pushed
the
xavdid/use-native-uuid
branch
from
d52c170
to
e071567
Compare
xavdid-stripe
commented
Oct 18, 2022
|
@richardm-stripe Ok, I pushed a tweak to your test so we only mock when the function was otherwise available. Mind giving it a quick review when you have a chance? |
|
Ope! Turns out auto-merge doesn't wait for reviewers 🤔 Probably still take a peek and lmk if you see anything we should tweak. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101 by using the native UUID implementation, if available. Added a (very) basic test as a starter.