Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split resource and service types #1624

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Nov 21, 2022

Splits resource object definitions from the resource implementation that contains methods and puts them into separate files.

Adds a typescript test project.

Sanity checked by running:

git checkout master
grep -ohEi 'interface \w+' -R types/2022-11-15 | sort > /tmp/before.txt
git checkout pakrym/Split_resource_and_service_types
grep -ohEi 'interface \w+' -R types/2022-11-15 | sort > /tmp/after.txt
diff /tmp/before.txt /tmp/after.txt

@pakrym-stripe pakrym-stripe marked this pull request as ready for review November 22, 2022 16:15
@pakrym-stripe pakrym-stripe changed the title [WIP] Split resource and service types Split resource and service types Nov 22, 2022
@richardm-stripe
Copy link
Contributor

richardm-stripe commented Nov 22, 2022

LGTM.

@pakrym-stripe pakrym-stripe merged commit 38fe896 into master Nov 22, 2022
@remi-stripe remi-stripe deleted the pakrym/Split_resource_and_service_types branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants