-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Updates for beta branch #1666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Separate stripe into worker and default entrypoints, needs tests for worker * Fix test, remove unused import * Actually require child_process * build * Convert tests to TypeScript, add browser field * Move more utils functions to nodeUtils * Use _utils defined on Stripe object * Add error messages to createNodeHttpClient and createNodeCryptoProvider * Move platform-specific utils to new PlatformFunctions classes, add tests * Abstract getUname to platform functions, set _platformFunctions on Webhooks * Make generic createCryptoProvider in Webhooks * Revert "Make generic createCryptoProvider in Webhooks" This reverts commit c8af4d5. * Remove stale file in lib * Create generic createHttpClient that creates FetchHttpClient by default in workers * Move getUname to PlatformFunctions (now returns a promise), and misc reviewer comments * Make generic createCryptoProvider in Webhooks * Removing this alias * Fix DefaultPlatformFunctions getUname, fix test * Add getMockPlatformFunctions test util, prefix _createCryptoProvider
pakrym-stripe
approved these changes
Jan 26, 2023
pakrym-stripe
requested changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we lost DEFAULT_API_VERSION setting logic
anniel-stripe
force-pushed
the
latest-codegen-beta
branch
from
January 26, 2023 20:30
8e30382
to
3acce48
Compare
pakrym-stripe
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi v221.
cc @stripe/api-libraries
Changelog
billing_agreement_id
onCheckoutSessionCreateParams.payment_method_options.paypal
list_transactions
method on resourceTax.Transaction
QuoteUpdateParams.subscription_data_overrides
fromarray(create_specs)
toemptyStringable(array(update_specs))