Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a ts-ignore by using Object.entries #2150

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Remove a ts-ignore by using Object.entries #2150

merged 2 commits into from
Aug 19, 2024

Conversation

QuentinLemCode
Copy link
Contributor

Hello

Very little PR : we can avoid a @ts-ignore by using Object.entries instead of Object.keys

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

xavdid-stripe
xavdid-stripe approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@xavdid-stripe xavdid-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@xavdid-stripe xavdid-stripe enabled auto-merge (squash) August 19, 2024 21:51
@xavdid-stripe xavdid-stripe merged commit 5fa60e5 into stripe:master Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid-stripe xavdid-stripe xavdid-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuentinLemCode @CLAassistant @xavdid-stripe