Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error type StripeIdempotencyError #412

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

yotamshacham
Copy link
Contributor

No description provided.

@ob-stripe
Copy link
Contributor

Hi @yotamshacham, thanks for the contribution!

This looks alright to me, but I know that @brandur-stripe was working on a similar feature for the Ruby library a few months back (cf. stripe/stripe-ruby#503), so I'll defer to him. He's away right now but will be back next week. Thanks for your patience!

r? @brandur-stripe

@brandur-stripe
Copy link
Contributor

Thanks @yotamshacham!

This looks alright to me, but I know that @brandur-stripe was working on a similar feature for the Ruby library a few months back (cf. stripe/stripe-ruby#503), so I'll defer to him. He's away right now but will be back next week. Thanks for your patience!

I think I forgot to mention it, but I ended up merging a formalized idempotency_error type in the backend implementation so stripe/stripe-ruby#503 is unblocked.

This one is also good to come in!

@brandur-stripe brandur-stripe merged commit aa4e13e into stripe:master Dec 5, 2017
@brandur-stripe
Copy link
Contributor

Released as 5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants