Update subscriptions tests to pass with new API changes #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
reviewed
Feb 13, 2018
test/flows.spec.js
Outdated
| currency: CURRENCY, | ||
| interval: 'month', | ||
| nickname: 'Gold Super Amazing Tier', | ||
| product: product.id, |
There was a problem hiding this comment.
You can create the plan and product in a single API request, by passing a dictionary for the product parameter. In the interest of making the test suite faster (until we move to stripe-mock 🤞 ), maybe that'd be preferable?
There was a problem hiding this comment.
Ah, excellent point! Updated.
ptal @ob-stripe
Version 2018-02-05 came with a major change to plans and products: * Products now have a `type` which is `service` or `good`. * Plans have `name` change to `nickname`. * Plans now take a product (of `type=service`) on creation.
brandur-stripe
force-pushed
the
brandur-fix-plans
branch
from
4514bbe
to
0c1973d
Compare
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2018-02-05 came with a major change to plans and products:
typewhich isserviceorgood.namechange tonickname.type=service) on creation.Testing on
masteris currently broken. This patch updates some test suites toallow for the new API changes and fixes the suite.
r? @ob-stripe