Add ScheduledQueryRun resource #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-sigma-scheduled-query-run
branch
from
0cc79e1
to
0654718
Compare
|
Looks awesome to me. |
lib/stripe.js
Outdated
| @@ -83,6 +83,9 @@ var resources = { | |||
| Transactions: require('./resources/Issuing/Transactions'), | |||
| Disputes: require('./resources/Issuing/Disputes'), | |||
| }), | |||
| Sigma: resourceNamespace('sigma', { | |||
| ScheduledQueryRuns: require('./resources/Sigma/ScheduledQueryRun'), | |||
There was a problem hiding this comment.
It's kind of annoying, but I think the convention in Node is to have the filenames plural. Can we make this ScheduledQueryRuns?
There was a problem hiding this comment.
ah nice catch on that one. I just fixed it if you can take a second look
There was a problem hiding this comment.
I think you might've forgotten to commit a change :)
(The filename is modified, but this line is the same.)
There was a problem hiding this comment.
Damn sorry about that, totally forgot to fix that line. I re-ran the test suite to be safe and it all passes now!
|
Minor comment, but looks good! |
remi-stripe
force-pushed
the
remi-add-sigma-scheduled-query-run
branch
from
0654718
to
d8f988d
Compare
remi-stripe
force-pushed
the
remi-add-sigma-scheduled-query-run
branch
from
d8f988d
to
d28a1ca
Compare
|
Thanks for the fixes! LGTM. |
|
Released as 6.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jlomas-stripe @brandur-stripe
cc @stripe/api-libraries