Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode Dates as Unix timestamps #574

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Encode Dates as Unix timestamps #574

merged 1 commit into from
Mar 11, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Encode Dates as Unix timestamps, using qs' serializeDate option.

Fixes #569.

@remi-stripe
Copy link
Contributor

That LGTM but re-assigning to @rattrayalex-stripe to be safe

@rattrayalex-stripe
Copy link
Contributor

rattrayalex-stripe commented Mar 1, 2019

Double-checking that we don't expect another datetime format anywhere in the API...

@rattrayalex-stripe
Copy link
Contributor

LGTM

Thanks for this ob!

@ob-stripe ob-stripe merged commit 4238f12 into master Mar 11, 2019
@ob-stripe ob-stripe deleted the ob-encode-dates branch March 11, 2019 16:36
@ob-stripe
Copy link
Contributor Author

Released as 6.26.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants