Flatten parameters in multipart requests #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not sure this will work as desired with arrays – can we add a test?
r? @ob-stripe
|
@rattrayalex-stripe TBC, you should only pass params objects to |
|
Ah okay. LGTM |
ob-stripe
force-pushed
the
ob-multipart-flatten
branch
from
77b7367
to
3cb25ee
Compare
|
Thanks Alex! |
This was referenced Nov 29, 2019
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @rattrayalex-stripe
cc @stripe/api-libraries
Allows for nested parameters in multipart requests (i.e. file creation requests).