Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten parameters in multipart requests #600

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Flatten parameters in multipart requests #600

merged 1 commit into from
Apr 26, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @rattrayalex-stripe
cc @stripe/api-libraries

Allows for nested parameters in multipart requests (i.e. file creation requests).

rattrayalex-stripe
rattrayalex-stripe reviewed Apr 26, 2019
View reviewed changes
rattrayalex-stripe
rattrayalex-stripe reviewed Apr 26, 2019
View reviewed changes
Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this will work as desired with arrays – can we add a test?

r? @ob-stripe

@ob-stripe
Copy link
Contributor Author

@rattrayalex-stripe TBC, you should only pass params objects to flattenAndStringify, it's not meant to work with arrays. But I can add a check and an explicit error if you think that's preferable.

@rattrayalex-stripe
Copy link
Contributor

Ah okay.

LGTM

@ob-stripe ob-stripe force-pushed the ob-multipart-flatten branch from 77b7367 to 3cb25ee Compare April 26, 2019 22:23
@ob-stripe
Copy link
Contributor Author

Thanks Alex!

@ob-stripe ob-stripe merged commit 456bd21 into master Apr 26, 2019
@ob-stripe ob-stripe deleted the ob-multipart-flatten branch April 26, 2019 22:49
This was referenced Nov 29, 2019
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
This was referenced Apr 2, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2020
Merged
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
@ob-stripe
Merge pull request stripe#600 from stripe/ob-multipart-flatten
9e060ae 
Flatten parameters in multipart requests
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
@ob-stripe
Merge pull request stripe#600 from stripe/ob-multipart-flatten
2e9777c 
Flatten parameters in multipart requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rattrayalex-stripe rattrayalex-stripe rattrayalex-stripe left review comments

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @rattrayalex-stripe