[WIP] Rename more parameters to match OpenAPI #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add lebab and a script to run it * lebab transform: arrow * lebab transform: arg-rest * lebab transform: arg-spread * lebab transform: obj-method * lebab transform: obj-shorthand * lebab transform: let * lebab transform: template * lebab transform: default-param * lebab transform: destruct-param * lebab transform: includes * Revert "Add lebab and a script to run it" This reverts commit 70fd492. * Revert "lebab transform: destruct-param" because its changes didn't seem good. This reverts commit b56f52d. * Revert "lebab transform: default-param" because it seems dangerous / backwards-incompatible. This reverts commit 7eba992. * Unrelated: mark 8.1 as minimum 8-series version * Add mocha-only script * Use arrows in more places * Loosen some eslint rules I don't love
🔥Remove deprecated methods 🔥
Add VSCode and EditorConfig files
Drop support for Node 9 and bump dependencies to latest versions
* Misc. manual formatting * Fix some unit tests * Roll back path argument name changes * Misc. manual formatting
Remove legacy parameter support in invoices.retrieveUpcoming()
irace-stripe
changed the title
rattrayalex-stripe
approved these changes
May 10, 2019
|
test failure looks probably real also FYI I will be removing |
|
@rattrayalex-stripe Yeah, I need to fix the tests, hence WIP. I shouldn’t have tagged you on this yet, that’s my mistake. |
|
#625 removes |
…:stripe/stripe-node into irace-rename-parameters-to-match-openapi
|
@rattrayalex-stripe I still have one failing spec I can’t seem to figure out, in case you possibly have some insight 🙏 |
|
Looks like we need to remove |
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
4 times, most recently
from
9fdad65
to
cdea81a
Compare
|
@rattrayalex-stripe Is this still a valid PR or was it obviated by something else you did? |
|
Oops, good catch – thanks! This has been incorporated via other PR's ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.