Update README retry code sample to use two retries #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking at retry code samples across client libraries recently, we happened to notice that all the other ones use two retries as an example while stripe-node uses one. Definitely not adverse to changing this number everywhere at some point if we think it's right move, but for now just doing the incremental improvement of making stripe-node consistent with the other libraries.
ob-stripe
suggested changes
Jul 12, 2019
Co-Authored-By: Olivier Bellone <ob@stripe.com>
|
Welp, I guess that teaches me a lesson about why self approvals are a bad idea haha. Nothing gets by you Olivier ;) Thanks! |
|
Haha, you're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at retry code samples across client libraries recently, we
happened to notice that all the other ones use two retries as an example
while stripe-node uses one.
Definitely not adverse to changing this number everywhere at some point
if we think it's right move, but for now just doing the incremental
improvement of making stripe-node consistent with the other libraries.
r? @brandur-stripe (Tiny change. Going to self-approve this one.)