New config object #703
Merged
New config object #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulasjes-stripe
force-pushed
the
paulasjes/new-config-object
branch
from
24e9c23
to
0b03619
Compare
rattrayalex-stripe
approved these changes
Nov 5, 2019
rattrayalex-stripe
approved these changes
Nov 5, 2019
rattrayalex-stripe
approved these changes
Nov 5, 2019
rattrayalex-stripe
approved these changes
Nov 5, 2019
rattrayalex-stripe
approved these changes
Nov 5, 2019
|
@rattrayalex-stripe npm is not updated with the new release version. |
|
Released as 7.13.0 |
acomagu
added a commit
to acomagu/DefinitelyTyped
that referenced
this pull request
Dec 5, 2019
acomagu
added a commit
to acomagu/DefinitelyTyped
that referenced
this pull request
Dec 5, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long running branch for the changes outlined in #640
Steps to complete before this can be merged:
setApiVersionto be set via a config object in the Stripe object initialization, with the intention of deprecatingstripe.setApiVersionsetMaxNetworkRetiresto be set via the config objectI'll open this up for review once the previous steps are completed.This is now ready for review! All the code in the PR was previously reviewed (see branches that were merged into this one). This should theoretically be an easy thumbs up.
r? @rattrayalex-stripe @ob-stripe
cc: @stripe/api-libraries