Add types dir to npmignore whitelist and stop warning when instantiating stripe with no args #757

rattrayalex-stripe · 2020-01-10T02:50:48Z

r? @jlomas-stripe
cc @stripe/api-libraries
Fixes #756

Tested in a repl:

> require('./lib/stripe')('hi'); 1
1
> require('./lib/stripe')('hi').customers.list(); 1
1
> (node:46965) UnhandledPromiseRejectionWarning: Error: Invalid API Key provided: hi

Note that it did not log warnings.

…ing stripe with no args (stripe#757) * Fix warnings when instantiating stripe with no options * Add types dir to npmignore whitelist

rattrayalex-stripe added 2 commits January 9, 2020 18:47

Fix warnings when instantiating stripe with no options

9b620d6

Add types dir to npmignore whitelist

9fdf9be

ob-stripe approved these changes Jan 10, 2020

View reviewed changes

ob-stripe assigned rattrayalex-stripe Jan 10, 2020

ob-stripe added the approved label Jan 10, 2020

rattrayalex-stripe merged commit 1a6cd58 into master Jan 10, 2020

rattrayalex-stripe deleted the ralex/v8-fixes branch January 10, 2020 03:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add types dir to npmignore whitelist and stop warning when instantiating stripe with no args #757

Add types dir to npmignore whitelist and stop warning when instantiating stripe with no args #757

rattrayalex-stripe commented Jan 10, 2020 •

edited

Loading

Add types dir to npmignore whitelist and stop warning when instantiating stripe with no args #757

Add types dir to npmignore whitelist and stop warning when instantiating stripe with no args #757

Conversation

rattrayalex-stripe commented Jan 10, 2020 • edited Loading

rattrayalex-stripe commented Jan 10, 2020 •

edited

Loading