Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types dir to npmignore whitelist and stop warning when instantiating stripe with no args #757

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

rattrayalex-stripe
Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe commented Jan 10, 2020

r? @jlomas-stripe
cc @stripe/api-libraries
Fixes #756

Tested in a repl:

> require('./lib/stripe')('hi'); 1
1
> require('./lib/stripe')('hi').customers.list(); 1
1
> (node:46965) UnhandledPromiseRejectionWarning: Error: Invalid API Key provided: hi

Note that it did not log warnings.

@rattrayalex-stripe rattrayalex-stripe merged commit 1a6cd58 into master Jan 10, 2020
@rattrayalex-stripe rattrayalex-stripe deleted the ralex/v8-fixes branch January 10, 2020 03:24
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
…ing stripe with no args (stripe#757)

* Fix warnings when instantiating stripe with no options

* Add types dir to npmignore whitelist
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
…ing stripe with no args (stripe#757)

* Fix warnings when instantiating stripe with no options

* Add types dir to npmignore whitelist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typescript] types are not being uploaded to npm
2 participants