Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file uploads with nested params #785

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

jlomas-stripe
Copy link
Contributor

@jlomas-stripe jlomas-stripe commented Jan 30, 2020

Previously we were getting our keys from a flattened object, but then using the flattened key to access the original object, so 💥.

Now with 100% less 💥.

r? @brandur-stripe
cc @stripe/api-libraries

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I can really get on board this fewer explosions campaign ;) LGTM! Crazy this wasn't sussed out sooner!

@brandur-stripe brandur-stripe merged commit a6181ec into master Jan 30, 2020
@brandur-stripe brandur-stripe deleted the jlomas/fix-file-create branch January 30, 2020 16:39
@brandur-stripe
Copy link
Contributor

Released as 8.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants