Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple API changes #895

Merged
merged 1 commit into from
May 19, 2020
Merged

Multiple API changes #895

merged 1 commit into from
May 19, 2020

Conversation

remi-stripe
Copy link
Contributor

Multiple API changes

  • Add support for issuing_dispute as a type on BalanceTransaction
  • Add balance_transactions as an array of BalanceTransaction on Issuing Dispute
  • Add fingerprint and transaction_id in payment_method_details[alipay] on Charge
  • Add transfer_data[amount] on Invoice
  • Add transfer_data[amount_percent] on Subscription
  • Add price.created, price.deleted and price.updated on Event.

Codegen for openapi 58089ba

r? @cjavilla-stripe
cc @stripe/api-libraries

Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment. I'm like 99% sure these are correct going from optional to not optional, but pushing back to see if a typescript person can confirm these optional -> not optional changes are right

@@ -59,7 +59,7 @@ declare module 'stripe' {
/**
* The price of the line item.
*/
price?: Stripe.Price | null;
price: Stripe.Price | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure these prices moving from optional to not is fine. It's the one thing that sticks out to me the most in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's fine in node because it's a TS definition and it doesn't impact other libs because it's a string/object. If it was a long or decimal that'd be breaking in dotnet :p

@remi-stripe remi-stripe merged commit 8d80006 into master May 19, 2020
@remi-stripe remi-stripe deleted the remi/codegen-58089ba branch May 19, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants