Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple API changes #897

Merged
merged 1 commit into from
May 20, 2020
Merged

Multiple API changes #897

merged 1 commit into from
May 20, 2020

Conversation

remi-stripe
Copy link
Contributor

Multiple API changes:

  • Add anticipation_repayment as a type on BalanceTransaction
  • Add interac_present as a type on PaymentMethod
  • Add payment_method_details[interac_present] on Charge
  • Add transfer_data on SubscriptionSchedule

Codegen for openapi a8528a8

r? @cjavilla-stripe
cc @stripe/api-libraries

cjavilla-stripe
cjavilla-stripe reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 2 comments about which Im not certain. The rest lgtm tho

types/2020-03-02/Checkout/Sessions.d.ts Show resolved Hide resolved
cjavilla-stripe
cjavilla-stripe approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remi-stripe remi-stripe merged commit b844cfe into master May 20, 2020
@remi-stripe remi-stripe deleted the remi/codegen-a8528a8 branch May 20, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjavilla-stripe cjavilla-stripe cjavilla-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-stripe @cjavilla-stripe